Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer secret selection on edit command #929

Merged
merged 1 commit into from Sep 16, 2018

Conversation

@dominikschulz
Copy link
Contributor

commented Sep 15, 2018

This commit adds the secret selection wizard to
the edit command as well. This is triggered in
case no exact match was found. If the user aborts
the wizard then this is handled as if a new secret
was to be created.

Fixes #927

@dominikschulz dominikschulz added this to the 1.8.3 - Bugfix release milestone Sep 15, 2018
@dominikschulz dominikschulz force-pushed the dominikschulz:feature/issue-927 branch from 55444cc to 9474b9c Sep 15, 2018
Copy link
Contributor

left a comment

LGTM, see comment.

@martinhoefling

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2018

I think the behavior of selecting a secret as implemented here is much better. Not sure if creating a new one in the abort case is understood. Maybe one can initialize the secret with a comment or so? Alternatively abort means abort and the command is terminated. Edit implies to me that the secret exists already.

@dominikschulz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2018

Ok, good idea. We originally implemented this as pass did, but I agree. It's confusing. Maybe we should add a switch to edit if you want to (possibly) create a new secret and otherwise fail if it doesn't exist already.

This commit adds the secret selection wizard to
the edit command as well. This is triggered in
case no exact match was found. If the user aborts
the wizard then this is handled as if a new secret
was to be created.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz force-pushed the dominikschulz:feature/issue-927 branch from 9474b9c to 0c477ef Sep 16, 2018
@dominikschulz dominikschulz merged commit 74d81fc into gopasspw:master Sep 16, 2018
2 of 3 checks passed
2 of 3 checks passed
codecov/project 63.74% (-0.07%) compared to af794f6
Details
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dominikschulz dominikschulz deleted the dominikschulz:feature/issue-927 branch Sep 16, 2018
@nilskuhn

This comment has been minimized.

Copy link

commented Sep 17, 2018

@dominikschulz Great, that you realized this one so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.