Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle already mounted and not initialized errors #945

Merged
merged 1 commit into from Sep 28, 2018

Conversation

@dominikschulz
Copy link
Contributor

commented Sep 28, 2018

This commit adds proper handling of already mounted
and not initialized errors during the mounts add command.

Fixes #942

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

This commit adds proper handling of already mounted
and not initialized errors during the mounts add command.

Fixes #942

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz force-pushed the dominikschulz:fix/issue-942 branch from c09eb8b to a73bbbd Sep 28, 2018
@codecov-io

This comment has been minimized.

Copy link

commented Sep 28, 2018

Codecov Report

Merging #945 into master will decrease coverage by 0.03%.
The diff coverage is 27.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #945      +/-   ##
=========================================
- Coverage   63.73%   63.7%   -0.03%     
=========================================
  Files         170     171       +1     
  Lines        9840    9855      +15     
=========================================
+ Hits         6271    6278       +7     
- Misses       2785    2793       +8     
  Partials      784     784
Impacted Files Coverage Δ
pkg/store/root/errors.go 0% <0%> (ø)
pkg/store/root/mount.go 50.91% <0%> (ø) ⬆️
pkg/action/mount.go 60.38% <50%> (-3.26%) ⬇️
pkg/action/init.go 33.07% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a894a...a73bbbd. Read the comment docs.

@dominikschulz dominikschulz merged commit fb7afc5 into gopasspw:master Sep 28, 2018
2 of 3 checks passed
2 of 3 checks passed
codecov/project 63.7% (-0.03%) compared to 40a894a
Details
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dominikschulz dominikschulz deleted the dominikschulz:fix/issue-942 branch Sep 28, 2018
@dominikschulz dominikschulz added this to the 1.8.3 - Bugfix release milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.