New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to github.com/shurcooL/go/generated #1

Closed
bradleyfalzon opened this Issue Apr 15, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@bradleyfalzon
Contributor

bradleyfalzon commented Apr 15, 2017

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 7, 2017

Contributor

I'll send a PR to resolve this issue soon. Edit: Sent PR #2.

Contributor

dmitshur commented Nov 7, 2017

I'll send a PR to resolve this issue soon. Edit: Sent PR #2.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 7, 2017

Contributor

Also, this staticcheck output is mildly amusing in this context. :)

main.go:17:20: analysis.IsFileGenerated is deprecated: Use generated.ParseFile instead, which is more well defined because it implements a specification.  (SA1019)

(/cc @dominikh FYI; your tool is mentioned.)

Contributor

dmitshur commented Nov 7, 2017

Also, this staticcheck output is mildly amusing in this context. :)

main.go:17:20: analysis.IsFileGenerated is deprecated: Use generated.ParseFile instead, which is more well defined because it implements a specification.  (SA1019)

(/cc @dominikh FYI; your tool is mentioned.)

@bradleyfalzon

This comment has been minimized.

Show comment
Hide comment
@bradleyfalzon

bradleyfalzon Nov 16, 2017

Contributor

The PR looks good, thanks @shurcooL, a minor change to my integration tests to use the new syntax so it's made GopherCI better, extra thanks for that. Just updating production now, will close the issue once done.

Contributor

bradleyfalzon commented Nov 16, 2017

The PR looks good, thanks @shurcooL, a minor change to my integration tests to use the new syntax so it's made GopherCI better, extra thanks for that. Just updating production now, will close the issue once done.

@bradleyfalzon

This comment has been minimized.

Show comment
Hide comment
@bradleyfalzon

bradleyfalzon Nov 16, 2017

Contributor

Thanks again!

Contributor

bradleyfalzon commented Nov 16, 2017

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment