New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated package analysis with a newer one. #2

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
2 participants
@dmitshur
Contributor

dmitshur commented Nov 7, 2017

Package analysis has been deprecated. It's old, and was created as an ad-hoc best-effort solution before there was a specification for declaring a .go file as generated.

It has been superseded by package github.com/shurcooL/go/generated, which implements that specification.

This change updates the code and README to use the newer package. The behavior is preserved as much as possible, but it should be more accurate at detecting the // Code generated … DO NOT EDIT. comment.

Replace use of deprecated package analysis with a newer one.
Package analysis has been deprecated. It's old, and was created as an
ad-hoc best-effort solution before there was a specification for
declaring a .go file as generated.

It has been superseded by package github.com/shurcooL/go/generated,
which implements that specification.

This change updates the code and README to use the newer package.
The behavior is preserved as much as possible, but it should be more
accurate at detecting the "// Code generated … DO NOT EDIT." comment.
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 15, 2017

Contributor

Friendly ping (after 7+ days).

Contributor

dmitshur commented Nov 15, 2017

Friendly ping (after 7+ days).

@bradleyfalzon

This comment has been minimized.

Show comment
Hide comment
@bradleyfalzon

bradleyfalzon Nov 15, 2017

Contributor

Thanks @shurcooL I'll get a look this evening.

Sincerest apologies for the delay, everything's happening at the moment.

EDIT: The reason it's delayed is because I want to run the GopherCI tests with this, it's already LGTM, but want to merge and immediately have time to respond to issues.

Contributor

bradleyfalzon commented Nov 15, 2017

Thanks @shurcooL I'll get a look this evening.

Sincerest apologies for the delay, everything's happening at the moment.

EDIT: The reason it's delayed is because I want to run the GopherCI tests with this, it's already LGTM, but want to merge and immediately have time to respond to issues.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 16, 2017

Contributor

No problem about the delay at all. I'm just pinging (after 7 days) to make it easier for you to track active PRs, that's all.

Contributor

dmitshur commented Nov 16, 2017

No problem about the delay at all. I'm just pinging (after 7 days) to make it easier for you to track active PRs, that's all.

@bradleyfalzon bradleyfalzon merged commit 5e0ab75 into gopherci:master Nov 16, 2017

bradleyfalzon added a commit to bradleyfalzon/gopherci that referenced this pull request Nov 16, 2017

Update integration test to use "Code generated .* DO NOT EDIT" syntax
isFileGenerated has been updated to use this new syntax in
gopherci/isFileGenerated#2.

@dmitshur dmitshur deleted the dmitshur:use-new-generated-pkg branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment