add kannanenator solution #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi @kannanenator, I'll be reviewing your solution. I have a couple of minor suggestions, for which I'll comment in the PR in various places. Nice work! |
|
|
||
| filenamePtr := flag.String("filename", "problems.csv", "file containing the set of problems") | ||
| limitPtr := flag.Int("limit", 30, "quiz time limit") | ||
|
|
There was a problem hiding this comment.
I would add a check based on the NArg func in the flag pkg to handle the case where I try to run the game with no flags.
| fmt.Println("You got", numCorrect, "out of", numQs, "correct") | ||
| } | ||
|
|
||
| func handleError(err error){ |
There was a problem hiding this comment.
In my opinion, this kind of general error helper func is discouraged. While more verbose, we always prefer explicit handling at the call site. So instead of handleError, in each case where you get an error value, I would opt for using
log.Fatalf("could not open file: %v\n", err)or
// if you want to print to stderr and trigger an unsuccessful exit, for example
fmt.Fprintf(os.Stderr, "could not read input string: %v\n", err)
os.Exit(1)| for idx, element := range rows { | ||
| q, a := element[0], element[1] | ||
| fmt.Print("Problem #", idx+1 ,": ", q, " = ") | ||
| input, _ := consoleReader.ReadString('\n') |
There was a problem hiding this comment.
Dropping error values is a code smell, so unless your specific case calls for it, don't do it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.