New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to authenticate with application credential #1224

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 3, 2018

Build succeeded.

theopenlab-ci bot commented Sep 3, 2018

Build succeeded.

@jtopjian

This comment has been minimized.

Show comment
Hide comment
@jtopjian

jtopjian Sep 3, 2018

Collaborator

@zioproto Travis is flagging a go fmt error. If you can, run go fmt on the changed files - that should fix things up.

Collaborator

jtopjian commented Sep 3, 2018

@zioproto Travis is flagging a go fmt error. If you can, run go fmt on the changed files - that should fix things up.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 4, 2018

Coverage Status

Coverage decreased (-3.4%) to 75.955% when pulling ea7289e on zioproto:application_credential into 4014077 on gophercloud:master.

coveralls commented Sep 4, 2018

Coverage Status

Coverage decreased (-3.4%) to 75.955% when pulling ea7289e on zioproto:application_credential into 4014077 on gophercloud:master.

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 4, 2018

Build succeeded.

theopenlab-ci bot commented Sep 4, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 4, 2018

Build succeeded.

theopenlab-ci bot commented Sep 4, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 6, 2018

Build succeeded.

theopenlab-ci bot commented Sep 6, 2018

Build succeeded.

@zioproto

This comment has been minimized.

Show comment
Hide comment
@zioproto

zioproto Sep 7, 2018

Contributor

@RdL87 I pushed a new version of the patch that works with any possible combination of ID or NAME env vars. Can you review it ? Are you working on the tests ?

Contributor

zioproto commented Sep 7, 2018

@RdL87 I pushed a new version of the patch that works with any possible combination of ID or NAME env vars. Can you review it ? Are you working on the tests ?

@RdL87

This comment has been minimized.

Show comment
Hide comment
@RdL87

RdL87 Sep 7, 2018

@zioproto i'm working on this just now. So i'm going to recompile the client with the new library you've just pushed. I will ping you as soon as the keystone becomes available.

RdL87 commented Sep 7, 2018

@zioproto i'm working on this just now. So i'm going to recompile the client with the new library you've just pushed. I will ping you as soon as the keystone becomes available.

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 7, 2018

Build succeeded.

theopenlab-ci bot commented Sep 7, 2018

Build succeeded.

@zioproto zioproto changed the title from [wip] Add support to authenticate with application credential to Add support to authenticate with application credential Sep 14, 2018

@zioproto

This comment has been minimized.

Show comment
Hide comment
@zioproto

zioproto Sep 14, 2018

Contributor

@jtopjian I believe we are ready for review. I added two tests. I tried to to give correct code pointers to keystone codebase. thank you

Contributor

zioproto commented Sep 14, 2018

@jtopjian I believe we are ready for review. I added two tests. I tried to to give correct code pointers to keystone codebase. thank you

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 14, 2018

Build succeeded.

theopenlab-ci bot commented Sep 14, 2018

Build succeeded.

@jtopjian

@zioproto This is looking really good. :)

I think I found a good keystone reference to use: https://github.com/openstack/keystoneauth/blob/ebe781a3ea0386d6ff088a84e8dde26e538b856d/keystoneauth1/identity/v3/application_credential.py#L48-L67

It looks to match up really well with your other investigations.

The core functionality of this PR looks correct. The comments I left are just putting some final touches on things.

Let me know if you have any questions :)

Show outdated Hide outdated auth_options.go Outdated
Show resolved Hide resolved auth_options.go Outdated
Show resolved Hide resolved auth_options.go
Show resolved Hide resolved auth_options.go Outdated
Show resolved Hide resolved auth_options.go Outdated
@zioproto

This comment has been minimized.

Show comment
Hide comment
@zioproto

zioproto Sep 17, 2018

Contributor

Thanks for the review. I pushed changes that should address all the points of the review

Contributor

zioproto commented Sep 17, 2018

Thanks for the review. I pushed changes that should address all the points of the review

@theopenlab-ci

This comment has been minimized.

Show comment
Hide comment
@theopenlab-ci

theopenlab-ci bot Sep 17, 2018

Build succeeded.

theopenlab-ci bot commented Sep 17, 2018

Build succeeded.

@zioproto

This comment has been minimized.

Show comment
Hide comment
@zioproto

zioproto Sep 17, 2018

Contributor

@jtopjian I am not sure what the problem with the coveralls test not passing

Contributor

zioproto commented Sep 17, 2018

@jtopjian I am not sure what the problem with the coveralls test not passing

@jtopjian

This comment has been minimized.

Show comment
Hide comment
@jtopjian

jtopjian Sep 18, 2018

Collaborator

@zioproto You can ignore Coveralls. It acts weird sometimes.

Collaborator

jtopjian commented Sep 18, 2018

@zioproto You can ignore Coveralls. It acts weird sometimes.

@jtopjian

LGTM!

@zioproto @RdL87 Thank you both for your work on this.

@jtopjian jtopjian merged commit 45f1c76 into gophercloud:master Sep 18, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-3.4%) to 75.955%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
openlab/check check status: success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment