Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add support to authenticate with application credential #1224
Links to the line numbers/files in the OpenStack source code that support the
jtopjian left a comment
@zioproto This is looking really good. :)
I think I found a good keystone reference to use: https://github.com/openstack/keystoneauth/blob/ebe781a3ea0386d6ff088a84e8dde26e538b856d/keystoneauth1/identity/v3/application_credential.py#L48-L67
It looks to match up really well with your other investigations.
The core functionality of this PR looks correct. The comments I left are just putting some final touches on things.
Let me know if you have any questions :)