Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to authenticate with application credential #1224

Merged
merged 1 commit into from Sep 18, 2018

Conversation

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 3, 2018

Build succeeded.

@jtopjian
Copy link
Collaborator

@jtopjian jtopjian commented Sep 3, 2018

@zioproto Travis is flagging a go fmt error. If you can, run go fmt on the changed files - that should fix things up.

@zioproto zioproto force-pushed the zioproto:application_credential branch from eed9250 to ab38934 Sep 4, 2018
@coveralls
Copy link

@coveralls coveralls commented Sep 4, 2018

Coverage Status

Coverage decreased (-3.4%) to 75.955% when pulling ea7289e on zioproto:application_credential into 4014077 on gophercloud:master.

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 4, 2018

Build succeeded.

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 4, 2018

Build succeeded.

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 6, 2018

Build succeeded.

@zioproto zioproto force-pushed the zioproto:application_credential branch from bf17976 to 36601a1 Sep 7, 2018
@zioproto
Copy link
Contributor Author

@zioproto zioproto commented Sep 7, 2018

@RdL87 I pushed a new version of the patch that works with any possible combination of ID or NAME env vars. Can you review it ? Are you working on the tests ?

@RdL87
Copy link

@RdL87 RdL87 commented Sep 7, 2018

@zioproto i'm working on this just now. So i'm going to recompile the client with the new library you've just pushed. I will ping you as soon as the keystone becomes available.

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 7, 2018

Build succeeded.

@zioproto zioproto changed the title [wip] Add support to authenticate with application credential Add support to authenticate with application credential Sep 14, 2018
@zioproto zioproto force-pushed the zioproto:application_credential branch 3 times, most recently from c274c69 to 253e20e Sep 14, 2018
@zioproto
Copy link
Contributor Author

@zioproto zioproto commented Sep 14, 2018

@jtopjian I believe we are ready for review. I added two tests. I tried to to give correct code pointers to keystone codebase. thank you

@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 14, 2018

Build succeeded.

Copy link
Collaborator

@jtopjian jtopjian left a comment

@zioproto This is looking really good. :)

I think I found a good keystone reference to use: https://github.com/openstack/keystoneauth/blob/ebe781a3ea0386d6ff088a84e8dde26e538b856d/keystoneauth1/identity/v3/application_credential.py#L48-L67

It looks to match up really well with your other investigations.

The core functionality of this PR looks correct. The comments I left are just putting some final touches on things.

Let me know if you have any questions :)


} else if opts.ApplicationCredentialID != "" {
// Configure the request for ApplicationCredentialID authentication.
// https://github.com/openstack/keystone-specs/blob/master/specs/keystone/queens/application-credentials.rst#using-an-application-credential-to-obtain-a-token
auth_options.go Outdated Show resolved Hide resolved
auth_options.go Show resolved Hide resolved
auth_options.go Outdated Show resolved Hide resolved
auth_options.go Outdated Show resolved Hide resolved
@zioproto zioproto force-pushed the zioproto:application_credential branch from 253e20e to 9cbd52b Sep 17, 2018
@zioproto
Copy link
Contributor Author

@zioproto zioproto commented Sep 17, 2018

Thanks for the review. I pushed changes that should address all the points of the review

@zioproto zioproto force-pushed the zioproto:application_credential branch from 9cbd52b to ea7289e Sep 17, 2018
@theopenlab-ci
Copy link

@theopenlab-ci theopenlab-ci bot commented Sep 17, 2018

Build succeeded.

@zioproto
Copy link
Contributor Author

@zioproto zioproto commented Sep 17, 2018

@jtopjian I am not sure what the problem with the coveralls test not passing

@jtopjian
Copy link
Collaborator

@jtopjian jtopjian commented Sep 18, 2018

@zioproto You can ignore Coveralls. It acts weird sometimes.

Copy link
Collaborator

@jtopjian jtopjian left a comment

LGTM!

@zioproto @RdL87 Thank you both for your work on this.

@jtopjian jtopjian merged commit 45f1c76 into gophercloud:master Sep 18, 2018
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-3.4%) to 75.955%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
openlab/check check status: success
Details
@jobrs jobrs mentioned this pull request May 13, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.