Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request integrating a new CI system to Gophercloud #593

Merged
merged 1 commit into from Nov 3, 2017

Conversation

@liusheng
Copy link
Contributor

@liusheng liusheng commented Nov 3, 2017

I'd like to request to integrate a new CI system which built based on
zuul[1] and nodepool[2] tools to Gophercloud repo. It is for running
Gophercloud tests(both unit tests and acceptance tests) based on a
devstack[3] environment. For now, my colleagues and I have basicially
finish the CI system building, and have tested with Gophercloud, it can
work OK, please see[4]. We will long-term maintain the CI system and would
like to propose to intergrate with Gophercloud official repo.

FYI, the zuul jobs definition can be found in [5], the zuul jobs status web
page is [6], the test jobs log server is [7].

[1] https://docs.openstack.org/infra/zuul/
[2] https://docs.openstack.org/infra/nodepool/
[3] https://docs.openstack.org/devstack/latest/
[4] https://github.com/theopenlab/gophercloud/pull/5
[5] https://github.com/theopenlab/openlab-zuul-jobs
[6] http://80.158.20.68/
[7] http://80.158.20.68/logs/

For #592

@coveralls
Copy link

@coveralls coveralls commented Nov 3, 2017

Coverage Status

Coverage remained the same at 72.244% when pulling d9d5c0c on liu-sheng:592 into e7fa81e on gophercloud:master.

I'd like to request to integrate a new CI system which built based on
zuul[1] and nodepool[2] tools to Gophercloud repo. It is for running
Gophercloud tests(both unit tests and acceptance tests) based on a
devstack[3] environment. For now, my colleagues and I have basicially
finish the CI system building, and have tested with Gophercloud, it can
work OK, please see[4]. We will long-term maintain the CI system and would
like to propose to intergrate with Gophercloud official repo.

FYI, the zuul jobs definition can be found in [5], the zuul jobs status web
page is [6], the test jobs log server is [7].

[1] https://docs.openstack.org/infra/zuul/
[2] https://docs.openstack.org/infra/nodepool/
[3] https://docs.openstack.org/devstack/latest/
[4] https://github.com/theopenlab/gophercloud/pull/5
[5] https://github.com/theopenlab/openlab-zuul-jobs
[6] http://80.158.20.68/
[7] http://80.158.20.68/logs/

For #592
@liusheng liusheng force-pushed the liusheng:592 branch from d9d5c0c to f363989 Nov 3, 2017
@coveralls
Copy link

@coveralls coveralls commented Nov 3, 2017

Coverage Status

Coverage remained the same at 72.213% when pulling f363989 on liu-sheng:592 into 754e57e on gophercloud:master.

@jtopjian
Copy link
Collaborator

@jtopjian jtopjian commented Nov 3, 2017

I'm going to go ahead and merge this. I'll fully admit that I have no knowledge of Zuul, so if there are any errors, please submit follow-up PRs for fixes :)

I suggest leaving #592 open until everything is confirmed to work. PRs which fix the .zuul.yaml file can reference #592.

@jtopjian jtopjian merged commit 6f1b7d4 into gophercloud:master Nov 3, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.213%
Details
@liusheng liusheng deleted the liusheng:592 branch Dec 19, 2017
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
openstack_networking_network_v2 was originally created with the fields
"admin_state_up" and "shared" as TypeString. This was to work around
Terraform mistaking an omitted boolean argument as "false".

Now that `GetOkExists` is available, we can correctly account for this
case.

This commit changes these two fields to TypeBool while still retaining
the prior behavior that TypeString was working around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants