Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: regenerate with GopherJS 1.12-2 and Go 1.12.13 #72

merged 4 commits into from Dec 2, 2019


Copy link

dmitshur commented Dec 1, 2019

Also add support for syscall/js and start using it in the initial snippet.

Make various modernizations/improvements to the script.

Fixes #69.

/cc @hajimehoshi @slimsag

(See individual commits with descriptive commit messages.)

dmitshur added 4 commits Dec 1, 2019
Also modify the default "hello world" snippet to use it,
since it's a more general API.

Modernize slightly to handle variability in
environments better.

Updates #69
Previously, the script relied on GOROOT not being user-writable and
failed when that wasn't the case. This change makes it succeed in
both cases.

Fixes #69
GopherJS 1.12-2 has added support for syscall/js package,
so it should be available as part of imports.

The syscall/js API is not included in the GOROOT/api/go1.*.txt files
at this time, and so it needs to be added to mkstdlib.go explicitly.
Use the mkapi.go program to determine the syscall/js API.

Regenerate zstdlib.go with the updated generator, using Go 1.12.13:

	go1.12.13 generate

Updates golang/go#27590
Done on darwin/amd64 environment.

Regenerated with:

	go get
	go1.12.13 generate

This comment has been minimized.

Copy link

hajimehoshi commented Dec 1, 2019

I'm not familiar with the playground, so I'll defer this to @slimsag


This comment has been minimized.

Copy link
Member Author

dmitshur commented Dec 1, 2019

The playground doesn't really need much review (and we don't have much reviewer time available due to gopherjs/gopherjs#894), it just needs to continue to work. I've tested and will ensure it does.

If someone spots a problem in one of the commits, let me know, otherwise I plan to merge later today.

@dmitshur dmitshur merged commit bc5ba08 into master Dec 2, 2019
@dmitshur dmitshur deleted the update-latest branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.