Permalink
Browse files

tests: Improve description of issue5856 test.

It fails when source map support is disabled, but passes when it's
enabled. But CI has it disabled at this time.
  • Loading branch information...
1 parent 12846d3 commit 898011140c105ef3e80ab44b3c0ae94278b3e33f @shurcooL shurcooL committed Dec 16, 2016
Showing with 4 additions and 3 deletions.
  1. +4 −3 tests/run.go
View
@@ -62,7 +62,7 @@ var knownFails = map[string]failReason{
"fixedbugs/issue4388.go": {desc: "Error: expected <autogenerated>:1 have anonymous function:0"},
"fixedbugs/issue4562.go": {desc: "Error: cannot find issue4562.go on stack"},
"fixedbugs/issue4620.go": {desc: "map[0:1 1:2], Error: m[i] != 2"},
- "fixedbugs/issue5856.go": {desc: "BUG: defer called from /private/var/folders/tw/kgz4v2kn4n7d7ryg5k_z3dk40000gn/T/issue5856.go.931062983:15135, want issue5856.go:28"},
+ "fixedbugs/issue5856.go": {category: requiresSourceMapSupport},
"fixedbugs/issue6899.go": {desc: "incorrect output -0"},
"fixedbugs/issue7550.go": {desc: "FATAL ERROR: invalid table size Allocation failed - process out of memory"},
"fixedbugs/issue7690.go": {desc: "Error: runtime error: slice bounds out of range"},
@@ -96,8 +96,9 @@ var knownFails = map[string]failReason{
type failCategory uint8
const (
- other failCategory = iota
- usesUnsupportedPackage // Test fails because it imports an unsupported package, e.g., "unsafe".
+ other failCategory = iota
+ usesUnsupportedPackage // Test fails because it imports an unsupported package, e.g., "unsafe".
+ requiresSourceMapSupport // Test fails without source map support (as configured in CI), because it tries to check filename/line number via runtime.Caller.
compilerPanic
unsureIfGopherJSSupportsThisFeature
validButDealWithAfterGo17SinceNew // TODO: After Go 1.7 support is out, this category should be re-triaged and removed.

0 comments on commit 8980111

Please sign in to comment.