Please sign in to comment.
WIP: Vendor x/tools/go/importer, modify it to import go/types.
go/types defines some types just like golang.org/x/tools/go/types, but because they have different import paths, those types are not interchangeable. Not all packages have moved into Go standard library. Namely, golang.org/x/tools/go/importer and golang.org/x/tools/go/types/typeutil are still living in x/tools subrepo. While golang.org/x/tools/go/types/typeutil has been updated to import go/types in https://golang.org/cl/18207, it appears golang.org/x/tools/go/importer has not yet been updated in a similar way. So if we import it as is, we would have incompatible types defined in go/types and golang.org/x/tools/go/types. A temporary solution to have a working codebase is to vendor that package and modify it to import go/types. This can be undone as soon as the upstream package is modified to import go/types itself. I've asked about its status in the aforementioned CL, awaiting a reply in order to figure out the best plan forward.
- Loading branch information...
Showing with 1,002 additions and 2 deletions.
Oops, something went wrong.