Investigate why math.TestGamma needs slightly increase tolerances to pass in GopherJS 1.8-1. #589

shurcooL opened this Issue Feb 17, 2017 · 0 comments


None yet

1 participant


See 5e896be.

The TODO says:

// TODO: Is there a better way to fix TestGamma? It's weird that only one test
//       requires increasing tolerances. Perhaps there's a better fix? Maybe we
//       should override TestGamma specifically and not the package-wide tolerances,
//       because this will cause many other tests to be less accurate. Or maybe this
//       is fine?

@neelance commented:

I'm still wondering where exactly we're losing precision. I guess it is because we're using some JS native math functions which are implemented slightly differently than the Go ones. Investigate?

This issue is to track that investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment