New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Go 1.12 #887

Open
mewmew opened this Issue Dec 20, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@mewmew
Copy link

mewmew commented Dec 20, 2018

When trying to go get goherjs/gopherjs using Go 1.12 (one commit newer than go1.12beta1, golang/go@9ed9df6), I get the following error:

$ go get -u github.com/gopherjs/gopherjs
# github.com/gopherjs/gopherjs/compiler
goget/src/github.com/gopherjs/gopherjs/compiler/compiler.go:20:9: undefined: ___GOPHERJS_REQUIRES_GO_VERSION_1_11___

As I did not find any open issues about this, I just wanted to write about the workaround for this error I'm currently using until gopherjs gets support for Go 1.12.

$ cd $GOPATH/src/github.com/gopherjs/gopherjs
$ git remote add myitcv https://github.com/myitcv/gopherjs
$ git fetch myitcv
$ git checkout go1.12
$ go get ./...

This successfully compiles GopherJS for Go 1.12.

$ gopherjs version
GopherJS 1.12.0

Cheers,
Robin

@myitcv

This comment has been minimized.

Copy link
Member

myitcv commented Dec 21, 2018

@mewmew - just to point out the support on the go1.12 branch of my fork is still WIP (myitcv#41)

@mewmew

This comment has been minimized.

Copy link

mewmew commented Dec 21, 2018

@mewmew - just to point out the support on the go1.12 branch of my fork is still WIP (myitcv#41)

Hi @myitcv,

Thanks for the notice. I ran into some issue with runtime/value.go (something about not being able to convert int8* to unsafe.Pointer). So for now, I'm back at the stable Go 1.11 release.

Cheers,
Robin

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Dec 22, 2018

As I did not find any open issues about this

Yes, we should absolutely add support for Go 1.12. Thanks for opening an issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment