compiler/natives: add missing runtime/pprof.Profile methods #588

Merged
merged 1 commit into from Feb 16, 2017

Projects

None yet

3 participants

@fjl
Contributor
fjl commented Feb 15, 2017

I need this change to build "github.com/rcrowley/go-metrics" as a dependency of my program.

@shurcooL

This package is documented as not supported, so it's fine to have an empty implementation.

We already have WriteTo method, so supporting the rest seems okay to me.

LGTM.

@fjl
Contributor
fjl commented Feb 16, 2017

Unrelated question: I also need "os/user", would you support adding a noop implementation to gopherjs? Right now packages that need "os/user" can't be compiled because it needs cgo.

@shurcooL
Member

What are you doing that needs os/user? Is it an option to not use it via build tags?

@neelance
Member

LGTM, thanks for contributing.

@neelance neelance merged commit d5c6ba6 into gopherjs:master Feb 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment