Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Minor readabilty improvements #713
Thanks for the PR. I agree these changes are an improvement.
However, I remember seeing an exact same (or very similar) change in the past (edit: found it, see #596 (comment) and 564024c), and @neelance rejected it then, because he preferred the current style at the time.
However, it was a few years ago (edit: actually, only 8~ months ago), and I wouldn't be surprised if he's okay with this code simplification now. I think we should merge it, because the code is simpler, and it allows other people who read it not get distracted and want to send a PR just like this one.