New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade to CircleCI 2.0. #864

Merged
merged 7 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@dmitshur
Member

dmitshur commented Oct 3, 2018

This is a minimal diff change to upgrade from CircleCI 1.0 to 2.0 and get it working, since 1.0 has been EOLed. The goal was to keep the config.yml file as simple as possible for now; we can consider changes and enhancements to it as part of future work.

Remove os/user package from being tested, since it's failing in the CircleCI 2.0 environment (see tracking issue #863).

Resolves #766.
Updates #797.

dmitshur added some commits Aug 25, 2018

WIP: Try to remove os/user test.
It's failing in this environment for some reason.
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 3, 2018

Member

It turns out that CircleCI 1.0 is deprecated but not yet outright removed. E.g., see https://circleci.com/gh/gopherjs/gopherjs/1650, which ran just now. So, getting this in isn't a pre-requisite for fixing #862.

Will leave it for another day in in case anyone has improvement suggestions.

Member

dmitshur commented Oct 3, 2018

It turns out that CircleCI 1.0 is deprecated but not yet outright removed. E.g., see https://circleci.com/gh/gopherjs/gopherjs/1650, which ran just now. So, getting this in isn't a pre-requisite for fixing #862.

Will leave it for another day in in case anyone has improvement suggestions.

@myitcv

This comment has been minimized.

Show comment
Hide comment
@myitcv

myitcv Oct 3, 2018

Contributor

@dmitshur what's the thinking behind creating this PR instead of fixing up #797?

Contributor

myitcv commented Oct 3, 2018

@dmitshur what's the thinking behind creating this PR instead of fixing up #797?

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 3, 2018

Member

I thought I left feedback on that PR, but looks like I didn't, sorry. I think I tried to tell you in person at GopherCon but didn't get a chance.

That PR was very helpful to me in figuring out CircleCI 2.0, so thank you for making it. That said, it makes many changes at once (changes from CircleCI 1.0 to 2.0, adds many comments/echos/whitespace, and introduces an exclusion list). I'd like to do a minimal migration first (as this PR does), and discuss the other changes second.

Member

dmitshur commented Oct 3, 2018

I thought I left feedback on that PR, but looks like I didn't, sorry. I think I tried to tell you in person at GopherCon but didn't get a chance.

That PR was very helpful to me in figuring out CircleCI 2.0, so thank you for making it. That said, it makes many changes at once (changes from CircleCI 1.0 to 2.0, adds many comments/echos/whitespace, and introduces an exclusion list). I'd like to do a minimal migration first (as this PR does), and discuss the other changes second.

@dmitshur dmitshur merged commit b337c87 into master Oct 4, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@dmitshur dmitshur deleted the ci2 branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment