Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use black list instead of white list for standard library tests #902

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@myitcv
Copy link
Member

myitcv commented Mar 9, 2019

Using a black list is a more effective mechanism for expressing those
standard library packages we don't want to test because it means we
don't need to manually check whether new standard library packages have
been added that would otherwise need to be added to the white list.

See the discussion in #900 for
more context.

ci: use black list instead of white list for standard library tests
Using a black list is a more effective mechanism for expressing those
standard library packages we don't want to test because it means we
don't need to manually check whether new standard library packages have
been added that would otherwise need to be added to the white list.

See the discussion in #900 for
more context.

@myitcv myitcv requested a review from hajimehoshi Mar 9, 2019

@hajimehoshi
Copy link
Member

hajimehoshi left a comment

lgtm

@hajimehoshi hajimehoshi merged commit a7e14a8 into gopherjs:master Mar 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.