Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade to Go 1.11.5 #903

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@myitcv
Copy link
Member

myitcv commented Mar 9, 2019

So that we can then see the true diff that the Go 1.12 changes in
#900 will introduce.

@myitcv myitcv requested a review from hajimehoshi Mar 9, 2019

@hajimehoshi

This comment has been minimized.

Copy link
Member

hajimehoshi commented Mar 9, 2019

Thank you!

# go run run.go -- fixedbugs/issue28688.go
exit status 2
Error: unknown shorthand flag: 'g' in -gcflags=-d=softfloat
Usage:
  gopherjs run [gofiles...] [arguments...] [flags]

Flags:
      --color         colored output
  -h, --help          help for run
      --localmap      use local paths for sourcemap
  -m, --minify        minify generated code
  -q, --quiet         suppress non-fatal warnings
      --tags string   a list of build tags to consider satisfied during the build
  -v, --verbose       print the names of packages as they are compiled


FAIL	fixedbugs/issue28688.go	0.006s

Is this an intended error?

ci: upgrade to Go 1.11.5
So that we can then see the true diff that the Go 1.12 changes in
#900 will introduce.

@myitcv myitcv force-pushed the myitcv:go1.11.5 branch from ecac41d to cd658a9 Mar 9, 2019

@myitcv

This comment has been minimized.

Copy link
Member Author

myitcv commented Mar 9, 2019

@hajimehoshi - the way the error is reported looks like another issue, but this test can itself be ignored because it looks related to checking runtime optimisations. Hence I've added it to the list of notApplicable tests that can be ignored.

@hajimehoshi
Copy link
Member

hajimehoshi left a comment

lgtm (as long as the tests succeed)

@myitcv myitcv merged commit 847fc94 into gopherjs:master Mar 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@myitcv myitcv deleted the myitcv:go1.11.5 branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.