Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler/natives/src/time: disable TestSleep #911

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@hajimehoshi
Copy link
Member

hajimehoshi commented Apr 10, 2019

As time.Now() is not accurate enough, the test time_test.TestSleep is flaky. This PR disables the test.

@hajimehoshi hajimehoshi requested review from neelance and dmitshur Apr 10, 2019

@hajimehoshi hajimehoshi merged commit bd77b11 into master Apr 11, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hajimehoshi hajimehoshi deleted the sleep branch Apr 11, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Apr 14, 2019

Minor, but it would be nicer to merge a small PR like this via the "squash and merge" strategy, so it would generate just 1 commit on master branch rather than two:

This is because we're trying to follow the convention set by the Go project.

@hajimehoshi

This comment has been minimized.

Copy link
Member Author

hajimehoshi commented Apr 15, 2019

Certainly. I'll be careful later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.