Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syscalls does not yet support version 12.0.0 #935

Closed
wants to merge 1 commit into from

Conversation

@pjdufour
Copy link

pjdufour commented Aug 18, 2019

Syscalls are not compiling on Ubuntu for NodeJS 12. This PR simply updates the docs to show how to use an older version of Node with syscalls.

@@ -13,14 +13,24 @@ The JavaScript environment of a web browser is completely isolated from your ope

### Node.js on Linux and macOS

GopherJS has support for system calls on Linux and macOS. Before running your code with Node.js, you need to install the system calls module. The module is compatible with Node.js version 10.0.0 (or newer). If you want to use an older version you can opt to not install the module, but then system calls are not available.
GopherJS has support for system calls on Linux and macOS. Before running your code with Node.js, you need to install the system calls module. The module is compatible with Node.js versions from 10.0.0 to 11.15.0 (Node.js version 12 is not yet supported). If you want to use an older version you can opt to not install the module, but then system calls are not available.

This comment has been minimized.

Copy link
@flimzy

flimzy Aug 18, 2019

Member

I would suggest changing this to:

version >= 10.0.0 and < 12.0.0

to remain valid if 11.15.1, or 11.16.0 are ever released.

@dmitshur dmitshur closed this in #949 Nov 6, 2019
dmitshur added a commit that referenced this pull request Nov 6, 2019
Some APIs were removed in Node 12, and new "safer" APIs must be used
instead. Perhaps this implementation is not the most elegant or produces
less then ideal error messages, but at least it compiles.

While at it, added an arena type to manage and gracefully free temporary
buffers we allocate for the duration of the call.

I couldn't find any tests for the syscall module, so I wrote a small one.

Closes #935

GitHub-Pull-Request: #949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.