Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler/natives/src/syscall: define more syscall functions for Darwin #940

Merged
merged 2 commits into from Sep 15, 2019

Conversation

@dmitshur
Copy link
Member

commented Sep 15, 2019

These are needed to be able to execute examples. After this change, gopherjs test reflect passes successfully.

Improve error when an unsupported signal is called, by making the signal name visible in the error message.

Many of the libc_aaa_trampoline to SYS_AAA mappings were based on golang/go@a3b0144.

Regenerate natives:

go generate github.com/gopherjs/gopherjs/compiler/natives
These are needed to be able to execute examples.
After this change, 'gopherjs test reflect' passes successfully.

Improve error when an unsupported signal is called,
by making the signal name visible in the error message.

Regenerate natives:

	go generate github.com/gopherjs/gopherjs/compiler/natives
Copy link
Member

left a comment

lgtm

This is enough to get all tests to pass on Darwin.

Regenerate natives.
@dmitshur dmitshur merged commit d3ddacd into master Sep 15, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@dmitshur dmitshur deleted the more-syscall-darwin branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.