Travis improvements #198
Merged
Travis improvements #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 5, 2016 00:33
Shikkic
approved these changes
Oct 7, 2016
| @@ -2,7 +2,7 @@ language: go | |||
| sudo: required | |||
| before_install: | |||
| - go get -d github.com/libgit2/git2go | |||
| - "$GOPATH/src/github.com/libgit2/git2go/script/install-libgit2.sh" | |||
| - "$GOPATH/src/github.com/libgit2/git2go/script/install-libgit2.sh 1>/dev/null" | |||
|
Glad to see all of our tests passing |
Shikkic
reviewed
Oct 7, 2016
| @@ -0,0 +1,11 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This is really nice, the script reduces our Travis runtime by like half since it only has to recursively run the tests once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185
I am unclear on certain functionality, so the test fixes may not make sense. Thoughts:
1: The go-get tests seem to not really be testing anything other than string concat which is worthless.
Also make files are garbage and I don't respect them.