Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More verdeps testing changes #203

Merged
merged 4 commits into from
Oct 17, 2016
Merged

More verdeps testing changes #203

merged 4 commits into from
Oct 17, 2016

Conversation

skeswa
Copy link
Contributor

@skeswa skeswa commented Oct 17, 2016

  • Added a standard github request service mock
  • Fixed the helpers_test.go linter errors (mostly by moving and redesigning MockFileInfo)
  • Re-wrote bytes_diffs_test.go to use goconvey
  • Re-formatted fetch_sha.go to stay within 80 characters per line (within reason)
  • Wrote tests for fetch_sha.go

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 47.35% when pulling 61cff42 on feature/verdeps-tests into a18a1a4 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 47.35% when pulling 61cff42 on feature/verdeps-tests into a18a1a4 on master.

Shikkic
Shikkic reviewed Oct 17, 2016
View reviewed changes
router/download_package_test.go
io.NewFakeFileInfo("archive.zip", 1234, false),
io.NewFakeFileInfo("archive.zip", 1235, false),
io.NewFakeFileInfo("archive.zip", 1236, false),
io.NewFakeFileInfo("akdjshfgaldfkjhjdfhgaksjhfg", 9999, false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought you hated buldge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was important they are out of order.

Shikkic
Shikkic approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@Shikkic Shikkic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I actually really like the goconvey BDD styling moving forward.

ZacharyThomas
ZacharyThomas reviewed Oct 17, 2016
View reviewed changes
lib/io/fake.go
@@ -0,0 +1,55 @@
package io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fake.go

real talk we should rename these files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha - fair

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed.

@coveralls
Copy link

coveralls commented Oct 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.7%) to 47.35% when pulling 0463561 on feature/verdeps-tests into a18a1a4 on master.

@ZacharyThomas
Copy link
Member

I don't like BDD because I am scum but okay. lgtm

@skeswa skeswa merged commit 3a5368b into master Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacharyThomas ZacharyThomas ZacharyThomas left review comments

@Shikkic Shikkic Shikkic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skeswa @coveralls @ZacharyThomas @Shikkic