Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory resource leak in OpenMP4Source() #101

Closed
invd opened this issue Jul 9, 2020 · 1 comment
Closed

memory resource leak in OpenMP4Source() #101

invd opened this issue Jul 9, 2020 · 1 comment

Comments

@invd
Copy link

invd commented Jul 9, 2020

The OpenMP4Source() function does not free the malloc()'ed memory for

mp4object *mp4 = (mp4object *)malloc(sizeof(mp4object));

when it is called with a MP4 input file that is smaller than 64 byte. This is due to the abort condition that misses a free(mp4):

if (mp4->filesize < 64) return 0;

This problem should not have any impact in practice since the caller will likely abort early and the memory will be reclaimed on program exit.

@dnewman-gpsw
Copy link
Collaborator

dnewman-gpsw commented Jul 9, 2020

Thanks, I have just fixed in on the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants