Bugfix/dont add failed emitters on observer schedule #872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a watch is being scheduled on a started observer, and the emitter
start
functions fails for some reason, future schedules of watches on the same path will "succeed" (won't raise), but no emitter thread will be started and no events will be reported. This is because the emitter is added to the observer's context before it is being started, and isn't removed on failure (it does onobserver.start()
, but not onobserver.schedule()
).I simply moved the line that adds the emitter to the observer's local context to after the line that starts it, so in case it raises it will be before the emitter was added to the observer context