Add SIGHUP termination signal to watchmedo #912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR registers SIGHUP as a termination signal for watchmedo. This is important for people who use watchmedo within terminal multiplexers such as tmux, as tmux causes all shells to send the SIGHUP signal when the session is closed. Since watchmedo ignores the SIGHUP handler, this causes the watchmedo process to continue running in the background, even though the shell running within tmux has been terminated.
As a workaround, I am working on writing a bash script that will convert the SIGHUP into a SIGINT before forwarding to watchmedo. However, I think it would be more intuitive for users if
watchmedo
would gracefully shut down when receiving SIGHUP in the first place.