New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix converting aria-* attribute names to camel case #630
Fix converting aria-* attribute names to camel case #630
Conversation
Thank you, just wanted to report this, when I spotted the PR :) |
2b2e813
to
65372f5
Compare
Any estimated time when this will be merged? I have this error currently as well and cannot build because of it :(, would be amazing if it gets pushed! @kamijin-fanta |
Will this PR be merged and released? Im getting this error in the browser dev tools with hero icons 2 (hi2). This either needs to be fixed or we need to migrate to another solution before we ship our application.
|
Agreed with the others, I am now getting this error and can't seem to solve it without an update to the package. Thank you in advance! |
Same here, I'm following. |
Yes, this would be helpful @kamijin-fanta 🙏 |
Hello, I understand that @kamijin-fanta can be busy these days, but is there any other contributor that can merge these changes? cc: @ethandaniel |
please merge! |
Let's merge this 🎉 |
Merge? :) |
react-icons@4.7.1 published now! thanks! |
@kamijin-fanta thank you!!! |
This PR fixes the new errors caused by hero icons 2 (
Invalid ARIA attribute ariaHidden. Did you mean aria-hidden.
) by non converting thearia-*
attributes names to camel case.cc: @kamijin-fanta