Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting aria-* attribute names to camel case #630

Conversation

bacali95
Copy link
Contributor

This PR fixes the new errors caused by hero icons 2 (Invalid ARIA attribute ariaHidden. Did you mean aria-hidden.) by non converting the aria-* attributes names to camel case.

cc: @kamijin-fanta

@bacali95 bacali95 mentioned this pull request Oct 18, 2022
@bali182
Copy link

bali182 commented Oct 20, 2022

Thank you, just wanted to report this, when I spotted the PR :)

@bacali95 bacali95 force-pushed the fix/fix-converting-aria-attr-to-camelCase branch from 2b2e813 to 65372f5 Compare October 24, 2022 18:04
@Hidde-Heijnen
Copy link

Any estimated time when this will be merged? I have this error currently as well and cannot build because of it :(, would be amazing if it gets pushed! @kamijin-fanta

@andi0b
Copy link

andi0b commented Nov 2, 2022

Will this PR be merged and released?

Im getting this error in the browser dev tools with hero icons 2 (hi2). This either needs to be fixed or we need to migrate to another solution before we ship our application.

Warning: Invalid ARIA attribute `ariaHidden`. Did you mean `aria-hidden`?

@graywolf336
Copy link

Agreed with the others, I am now getting this error and can't seem to solve it without an update to the package. Thank you in advance!

@RiccardoFerranti
Copy link

Same here, I'm following.
Thank you!

@gregonarash
Copy link

Yes, this would be helpful @kamijin-fanta 🙏

@bacali95
Copy link
Contributor Author

Hello, I understand that @kamijin-fanta can be busy these days, but is there any other contributor that can merge these changes? cc: @ethandaniel

@arickuter
Copy link

please merge!

@Metaphysics0
Copy link

Let's merge this 🎉

@davidreis97
Copy link

Merge? :)

@kamijin-fanta kamijin-fanta merged commit 42e1ed0 into react-icons:master Nov 28, 2022
@bacali95 bacali95 deleted the fix/fix-converting-aria-attr-to-camelCase branch November 28, 2022 09:18
@kamijin-fanta
Copy link
Member

react-icons@4.7.1 published now! thanks!

@graywolf336
Copy link

@kamijin-fanta thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet