Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement (optional) semver parsing of version #213

Merged
merged 4 commits into from Jun 15, 2020
Merged

Conversation

radeksimko
Copy link
Member

Fixes #157

I admit my JavaScript-fu is very rusty. I welcome any feedback. Also there's perhaps more changes outside of the context of the original problem - I'd be happy to extract these into separate PRs, if necessary.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #213 into master will decrease coverage by 1.74%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   90.76%   89.02%   -1.75%     
==========================================
  Files           4        4              
  Lines          65       82      +17     
  Branches        9       12       +3     
==========================================
+ Hits           59       73      +14     
- Misses          3        5       +2     
- Partials        3        4       +1     
Impacted Files Coverage Δ
src/github.ts 86.36% <83.33%> (-13.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0cc32...c5885ab. Read the comment docs.

@crazy-max
Copy link
Member

@radeksimko

I admit my JavaScript-fu is very rusty. I welcome any feedback.

Yeah me too hehe. I'll do a review soon. Thanks for your contribution!

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but my TS-fu is even worse than my JS-fu :D

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radeksimko The README would also need to be updated to address this new feature. And also run npm run pre-checkin and push changes. Thanks!

package.json Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
@radeksimko
Copy link
Member Author

@crazy-max I believe I addressed all your comments.

The implementation doesn't require GitHub token nor GitHub SDK anymore as it leverages the static JSON as discussed.

PTAL.

@crazy-max crazy-max self-requested a review June 15, 2020 16:04
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radeksimko LGTM!

@crazy-max crazy-max merged commit 62b67a0 into master Jun 15, 2020
1 of 3 checks passed
@crazy-max crazy-max deleted the f-semver branch June 15, 2020 16:05
crazy-max added a commit that referenced this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse goreleaser version as semver
3 participants