Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GORELEASER_CURRENT_TAG #259

Merged
merged 3 commits into from Nov 30, 2020
Merged

Set GORELEASER_CURRENT_TAG #259

merged 3 commits into from Nov 30, 2020

Conversation

crazy-max
Copy link
Member

Closes #255

@crazy-max crazy-max changed the title fix: Set GORELEASER_CURRENT_TAG (#255) Set GORELEASER_CURRENT_TAG (#255) Nov 22, 2020
@crazy-max crazy-max changed the title Set GORELEASER_CURRENT_TAG (#255) Set GORELEASER_CURRENT_TAG Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #259 (9972954) into master (50de962) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files           4        4           
  Lines          89       89           
  Branches       16       16           
=======================================
  Hits           79       79           
  Misses          5        5           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50de962...9972954. Read the comment docs.

@crazy-max crazy-max merged commit 09ce141 into master Nov 30, 2020
1 check passed
@crazy-max crazy-max deleted the fix-first-tag branch November 30, 2020 00:00
@spirosoik
Copy link

guys I think this merges causes a bug. When we pass GORELEASER_CURRENT_TAG it is not respected and uses always the latest tag :)

@crazy-max
Copy link
Member Author

crazy-max commented Dec 1, 2020

@spirosoik Tell me more, do you have a link to your repo? Can you open an issue about that please? Thanks!

@spirosoik
Copy link

It's a private repo but by the latest release doesn't respect the env variables provided there, more specificall GORELEASER_CURRENT_TAG. Downgraded to v2.3 and it works.

My action is:


      - name: Build & Dockers
        uses: goreleaser/goreleaser-action@v2.3.0
        with:
          args: --snapshot --skip-publish
          workdir: server
        env:
          GORELEASER_CURRENT_TAG: ${{ github.sha }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: git tag: uses first tag that matches commit and not the latest
3 participants