Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not force snapshot when nightly is set #321

Merged
merged 2 commits into from Jan 14, 2022
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jan 14, 2022

also moved the log to the proper location

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 requested a review from crazy-max as a code owner Jan 14, 2022
@caarlos0 caarlos0 self-assigned this Jan 14, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Jan 14, 2022
@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 14, 2022

Looks like prettier is not happy https://github.com/goreleaser/goreleaser-action/runs/4819360580?check_suite_focus=true#step:3:326

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Member Author

@caarlos0 caarlos0 commented Jan 14, 2022

Looks like prettier is not happy https://github.com/goreleaser/goreleaser-action/runs/4819360580?check_suite_focus=true#step:3:326

fixed

@codecov
Copy link

@codecov codecov bot commented Jan 14, 2022

Codecov Report

Merging #321 (b0a5edb) into master (5df302e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files           4        4           
  Lines         103      103           
  Branches       18       18           
=======================================
  Hits           82       82           
  Misses         13       13           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df302e...b0a5edb. Read the comment docs.

@crazy-max crazy-max merged commit 79d4afb into master Jan 14, 2022
23 checks passed
@crazy-max crazy-max deleted the nightly branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants