Skip to content
Permalink
Browse files

feat: skip_push on docker to match draft releases

  • Loading branch information...
caarlos0 committed Mar 24, 2018
1 parent 79a48ea commit b5818a7225acf5c35d7ed8700de1a8ab308b3dce
Showing with 33 additions and 0 deletions.
  1. +1 −0 config/config.go
  2. +5 −0 pipeline/docker/docker.go
  3. +27 −0 pipeline/docker/docker_test.go
@@ -183,6 +183,7 @@ type Docker struct {
Image string `yaml:",omitempty"`
Dockerfile string `yaml:",omitempty"`
Latest bool `yaml:",omitempty"`
SkipPush bool `yaml:"skip_push,omitempty"`
OldTagTemplate string `yaml:"tag_template,omitempty"`
TagTemplates []string `yaml:"tag_templates,omitempty"`
Files []string `yaml:"extra_files,omitempty"`
@@ -200,6 +200,11 @@ func publish(ctx *context.Context, docker config.Docker, images []string) error
log.Warn(pipeline.ErrSkipPublishEnabled.Error())
return nil
}
if docker.SkipPush {
// TODO: this should also be better handled
log.Warn(pipeline.Skip("skip_push is set").Error())
return nil
}
for _, image := range images {
if err := dockerPush(ctx, docker, image); err != nil {
return err
@@ -92,6 +92,33 @@ func TestRunPipe(t *testing.T) {
},
assertError: shouldNotErr,
},
"valid_skip_push": {
publish: true,
docker: config.Docker{
Image: registry + "goreleaser/test_run_pipe",
Goos: "linux",
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
SkipPush: true,
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"v{{.Major}}",
"v{{.Major}}.{{.Minor}}",
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
},
expect: []string{
registry + "goreleaser/test_run_pipe:v1.0.0-123",
registry + "goreleaser/test_run_pipe:v1",
registry + "goreleaser/test_run_pipe:v1.0",
registry + "goreleaser/test_run_pipe:latest",
},
assertError: shouldNotErr,
},
"valid_no_latest": {
publish: true,
docker: config.Docker{

0 comments on commit b5818a7

Please sign in to comment.
You can’t perform that action at this time.