Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add license to snapcraft #1010

Merged

Conversation

Projects
None yet
3 participants
@mgrachev
Copy link
Member

commented Apr 17, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #1010 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   88.32%   88.32%   +<.01%     
==========================================
  Files          52       52              
  Lines        2560     2562       +2     
==========================================
+ Hits         2261     2263       +2     
  Misses        236      236              
  Partials       63       63
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/snapcraft/snapcraft.go 88.28% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5901...77e8598. Read the comment docs.

@caarlos0

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Awesome, thanks @mgrachev !

@caarlos0 caarlos0 merged commit 3da2b37 into goreleaser:master Apr 17, 2019

4 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.32%)
Details
codecov/project 88.32% (+<.01%) compared to b8f5901
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mgrachev mgrachev deleted the mgrachev:feature/add-license-to-snapcraft branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.