Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base key to snapcraft #1011

Merged
merged 1 commit into from Apr 18, 2019
Merged

feat: add base key to snapcraft #1011

merged 1 commit into from Apr 18, 2019

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Apr 18, 2019

Hi there!

I've added the base key to the snapcraft pipe.

@codecov-io
Copy link

@codecov-io codecov-io commented Apr 18, 2019

Codecov Report

Merging #1011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   88.32%   88.33%   +<.01%     
==========================================
  Files          52       52              
  Lines        2562     2564       +2     
==========================================
+ Hits         2263     2265       +2     
  Misses        236      236              
  Partials       63       63
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/snapcraft/snapcraft.go 88.46% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da2b37...c61e127. Read the comment docs.

@caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 18, 2019

awesome, thank you! :D

@caarlos0 caarlos0 merged commit 2b8258f into goreleaser:master Apr 18, 2019
4 checks passed
@mgrachev mgrachev deleted the feature/add-base-to-snapcraft branch Apr 18, 2019
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants