Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base key to snapcraft #1011

merged 1 commit into from Apr 18, 2019


None yet
3 participants
Copy link

commented Apr 18, 2019

Hi there!

I've added the base key to the snapcraft pipe.


This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #1011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
+ Coverage   88.32%   88.33%   +<.01%     
  Files          52       52              
  Lines        2562     2564       +2     
+ Hits         2263     2265       +2     
  Misses        236      236              
  Partials       63       63
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/snapcraft/snapcraft.go 88.46% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da2b37...c61e127. Read the comment docs.


This comment has been minimized.

Copy link

commented Apr 18, 2019

awesome, thank you! :D

@caarlos0 caarlos0 merged commit 2b8258f into goreleaser:master Apr 18, 2019

4 checks passed

WIP ready for review
codecov/patch 100% of diff hit (target 88.32%)
codecov/project 88.33% (+<.01%) compared to 3da2b37
continuous-integration/travis-ci/pr The Travis CI build passed

@mgrachev mgrachev deleted the mgrachev:feature/add-base-to-snapcraft branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.