Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go-github #1012

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
3 participants
@mgrachev
Copy link
Member

commented Apr 22, 2019

Hi there!

I've updated go-github version to v25.0.1.
Since version v18.0.0, go-github uses go modules.

@mgrachev mgrachev requested a review from caarlos0 Apr 22, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          52       52           
  Lines        2564     2564           
=======================================
  Hits         2265     2265           
  Misses        236      236           
  Partials       63       63
Impacted Files Coverage Δ
internal/client/github.go 12.38% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8258f...60d61ed. Read the comment docs.

@caarlos0
Copy link
Member

left a comment

awesome, thanks!

@caarlos0 caarlos0 merged commit 73a08d5 into goreleaser:master Apr 22, 2019

4 checks passed

WIP ready for review
Details
codecov/patch Coverage not affected when comparing 2b8258f...60d61ed
Details
codecov/project 88.33% remains the same compared to 2b8258f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mgrachev mgrachev deleted the mgrachev:feature/update-go-github branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.