Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate valid brew formula #1048

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@mgrachev
Copy link
Member

commented Jun 11, 2019

closes #1047

@mgrachev mgrachev requested a review from caarlos0 Jun 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #1048 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          56       56           
  Lines        2765     2765           
=======================================
  Hits         2431     2431           
  Misses        262      262           
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef9906...4db8ef6. Read the comment docs.

@caarlos0

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

awesome, thanks!

@caarlos0 caarlos0 merged commit 3f082c9 into master Jun 11, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 1ef9906...4db8ef6
Details
codecov/project 87.92% remains the same compared to 1ef9906
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the hotfix/fix-brew-formula branch Jun 11, 2019

@rafaelmagu
Copy link

left a comment

I think the bug shifted a bit.

Show resolved Hide resolved internal/pipe/brew/template.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.