Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate valid brew formula #1048

Merged
merged 1 commit into from Jun 11, 2019
Merged

fix: generate valid brew formula #1048

merged 1 commit into from Jun 11, 2019

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Jun 11, 2019

closes #1047

@mgrachev mgrachev requested a review from caarlos0 Jun 11, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 11, 2019

Codecov Report

Merging #1048 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          56       56           
  Lines        2765     2765           
=======================================
  Hits         2431     2431           
  Misses        262      262           
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef9906...4db8ef6. Read the comment docs.

@caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 11, 2019

awesome, thanks!

@caarlos0 caarlos0 merged commit 3f082c9 into master Jun 11, 2019
5 checks passed
@caarlos0 caarlos0 deleted the hotfix/fix-brew-formula branch Jun 11, 2019
Copy link

@rafaelmagu rafaelmagu left a comment

I think the bug shifted a bit.

internal/pipe/brew/template.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants