Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add error handling #1111

Merged
merged 1 commit into from Aug 13, 2019
Merged

test: add error handling #1111

merged 1 commit into from Aug 13, 2019

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Aug 13, 2019

Hi there!

I've added additional error handling for 2 tests.

@derek derek bot added the invalid label Aug 13, 2019
@derek
Copy link

@derek derek bot commented Aug 13, 2019

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 13, 2019

Codecov Report

Merging #1111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1111   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          57       57           
  Lines        2969     2969           
=======================================
  Hits         2488     2488           
  Misses        401      401           
  Partials       80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b477ffa...26e76e4. Read the comment docs.

@caarlos0 caarlos0 merged commit 4100f65 into master Aug 13, 2019
5 checks passed
@caarlos0 caarlos0 deleted the feature/error-handling branch Aug 13, 2019
@caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 13, 2019

thanks!

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants