Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support arm for linuxbrew #1113

Merged
merged 1 commit into from Aug 13, 2019
Merged

feat: support arm for linuxbrew #1113

merged 1 commit into from Aug 13, 2019

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Aug 13, 2019

Hi there!

I've added support architecture arm for linuxbrew formulas.
I've used that formula as example https://github.com/Homebrew/linuxbrew-core/blob/c7f81028802006ba26b5e079556d1617b38ca495/Formula/openssl.rb#L58

/cc @caarlos0 @sethkor What do you think about it?

Close #1052

@mgrachev mgrachev force-pushed the feature/brew-arm-support branch 2 times, most recently from e24be83 to 48fc7b5 Aug 13, 2019
@mgrachev mgrachev requested a review from caarlos0 Aug 13, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 13, 2019

Codecov Report

Merging #1113 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   83.79%   83.51%   -0.29%     
==========================================
  Files          57       57              
  Lines        2969     2979      +10     
==========================================
  Hits         2488     2488              
- Misses        401      411      +10     
  Partials       80       80
Impacted Files Coverage Δ
internal/pipe/brew/brew.go 79.75% <0%> (-5.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4100f65...e036424. Read the comment docs.

Copy link
Member

@caarlos0 caarlos0 left a comment

awesome!

@mgrachev mgrachev force-pushed the feature/brew-arm-support branch from 48fc7b5 to 4799830 Aug 13, 2019
@mgrachev mgrachev force-pushed the feature/brew-arm-support branch from 4799830 to e036424 Aug 13, 2019
@caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 13, 2019

Awesome, thanks!

@caarlos0 caarlos0 merged commit de5676e into master Aug 13, 2019
3 of 5 checks passed
@caarlos0 caarlos0 deleted the feature/brew-arm-support branch Aug 13, 2019
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants