Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: artifact fields not available to flags #1118

merged 1 commit into from Aug 14, 2019


Copy link

@mgrachev mgrachev commented Aug 14, 2019

Hi there!

After these changes, an artifact fields will become available to flags.

Close #1115

@mgrachev mgrachev requested a review from caarlos0 Aug 14, 2019
@mgrachev mgrachev force-pushed the fix/artifact-fields branch from 17eeb0e to 747eac9 Aug 14, 2019
@mgrachev mgrachev force-pushed the fix/artifact-fields branch from 747eac9 to c5da08d Aug 14, 2019
Copy link

@codecov-io codecov-io commented Aug 14, 2019

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
  Coverage   81.56%   81.56%           
  Files          57       57           
  Lines        3109     3109           
  Hits         2536     2536           
  Misses        494      494           
  Partials       79       79
Impacted Files Coverage Δ
internal/builders/golang/build.go 98.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92bbe3...c5da08d. Read the comment docs.

@caarlos0 caarlos0 merged commit 1080215 into master Aug 14, 2019
5 checks passed
@caarlos0 caarlos0 deleted the fix/artifact-fields branch Aug 14, 2019
Copy link

@caarlos0 caarlos0 commented Aug 14, 2019

awesome, thanks!

Copy link

@github-actions github-actions bot commented Nov 19, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants