Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid pseudo version for github.com/go-macaron/cors #1138

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@ldez
Copy link
Contributor

commented Sep 6, 2019

Allow to build with go1.13 or with go1.11 and go1.12 with GOPROXY enable.

It's more a "workaround" than a real fix.
The problem need to be fixed by https://github.com/go-gitea/gitea.

Fixes #1132

@ldez ldez force-pushed the ldez:fix/macaron-cors branch 2 times, most recently from ff31171 to 99ac60b Sep 6, 2019

@ldez ldez force-pushed the ldez:fix/macaron-cors branch from 99ac60b to 51f0d10 Sep 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #1138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files          58       58           
  Lines        3253     3253           
=======================================
  Hits         2690     2690           
  Misses        481      481           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c08ab8...51f0d10. Read the comment docs.

@chenrui333
Copy link

left a comment

+1 adding the patch to homebrew PR: Homebrew/homebrew-core#43969

@chenrui333 chenrui333 referenced this pull request Sep 8, 2019

@caarlos0 caarlos0 merged commit 221416e into goreleaser:master Sep 9, 2019

4 checks passed

WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 2c08ab8...51f0d10
Details
codecov/project 82.69% remains the same compared to 2c08ab8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Thanks @chenrui333 🙏

@ldez ldez deleted the ldez:fix/macaron-cors branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.