Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): remove unused param #3248

Merged
merged 1 commit into from Jul 22, 2022
Merged

refactor(build): remove unused param #3248

merged 1 commit into from Jul 22, 2022

Conversation

caarlos0
Copy link
Member

we dont need to check the go version anymore, so we can remove all this
now.

we dont need to check the go version anymore, so we can remove all this
now.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Jul 21, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2022
@caarlos0 caarlos0 self-assigned this Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #3248 (7405594) into main (7aeebb1) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3248      +/-   ##
==========================================
- Coverage   84.29%   84.26%   -0.04%     
==========================================
  Files         115      115              
  Lines        9322     9302      -20     
==========================================
- Hits         7858     7838      -20     
  Misses       1183     1183              
  Partials      281      281              
Impacted Files Coverage Δ
internal/builders/buildtarget/targets.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aeebb1...7405594. Read the comment docs.

@caarlos0 caarlos0 merged commit 236e987 into main Jul 22, 2022
7 of 8 checks passed
@caarlos0 caarlos0 deleted the lint branch Jul 22, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant