Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: brew style #3274

Merged
merged 4 commits into from Aug 6, 2022
Merged

fix: brew style #3274

merged 4 commits into from Aug 6, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 1, 2022

closes #3236

closes #3236

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Aug 1, 2022
@caarlos0 caarlos0 self-assigned this Aug 1, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2022
@vercel vercel bot temporarily deployed to Preview August 1, 2022 19:15 Inactive
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #3274 (588d8aa) into main (b7687ec) will not change coverage.
The diff coverage is n/a.

Current head 588d8aa differs from pull request most recent head 6860270. Consider uploading reports for the commit 6860270 to get more accurate results

@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         115      115           
  Lines        9302     9302           
=======================================
  Hits         7838     7838           
  Misses       1183     1183           
  Partials      281      281           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 4, 2022 17:43 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member Author

caarlos0 commented Aug 4, 2022

Some formulas might still not pass brew style, but since its not required for taps to pass it, we'll leave as is.

@vercel vercel bot temporarily deployed to Preview August 4, 2022 17:48 Inactive
@caarlos0 caarlos0 merged commit d630605 into main Aug 6, 2022
6 checks passed
@caarlos0 caarlos0 deleted the brew-style branch August 6, 2022 22:00
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew: depends_on should be put before on_macos
1 participant