Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): compile with go 1.19 #3278

Merged
merged 11 commits into from Aug 6, 2022
Merged

feat(ci): compile with go 1.19 #3278

merged 11 commits into from Aug 6, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 2, 2022

https://go.dev/doc/go1.19

go 1.19 is out, compile with it

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 2, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 2, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 2, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Aug 3, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #3278 (c16ad71) into main (b7687ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3278      +/-   ##
==========================================
+ Coverage   84.26%   84.27%   +0.01%     
==========================================
  Files         115      116       +1     
  Lines        9302     9308       +6     
==========================================
+ Hits         7838     7844       +6     
  Misses       1183     1183              
  Partials      281      281              
Impacted Files Coverage Δ
pkg/config/config.go 95.18% <ø> (ø)
internal/testlib/tmpl.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit ee17c95 into main Aug 6, 2022
4 of 5 checks passed
@caarlos0 caarlos0 deleted the go1.19-ci branch Aug 6, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant