Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not push snaps concurrently #3295

Merged
merged 1 commit into from Aug 7, 2022
Merged

fix: do not push snaps concurrently #3295

merged 1 commit into from Aug 7, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 7, 2022

It seems that the error I get sometimes (#3257) is related to snap push
not being able to work concurrently.

I'm not a 100% sure though, so I'll try this and see how it goes.
If the error still happens, we can ignore the error or retry.

closes #3257

It seems that the error I get sometimes (#3257) is related to snap push
not being able to work concurrently.

I'm not a 100% sure though, so I'll try this and see how it goes.
If the error still happens, we can ignore the error or retry.

closes #3257
@caarlos0 caarlos0 added the bug Something isn't working label Aug 7, 2022
@caarlos0 caarlos0 self-assigned this Aug 7, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2022
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #3295 (244e4ab) into main (fa61448) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
- Coverage   84.28%   84.26%   -0.02%     
==========================================
  Files         116      116              
  Lines        9313     9311       -2     
==========================================
- Hits         7849     7846       -3     
- Misses       1183     1184       +1     
  Partials      281      281              
Impacted Files Coverage Δ
internal/pipe/snapcraft/snapcraft.go 85.04% <75.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 2fecd94 into main Aug 7, 2022
6 of 8 checks passed
@caarlos0 caarlos0 deleted the snap-push branch Aug 7, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retry snapcraft build/publish
1 participant