Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nfpm changelog support #3309

Merged
merged 4 commits into from Aug 16, 2022
Merged

feat: nfpm changelog support #3309

merged 4 commits into from Aug 16, 2022

Conversation

caarlos0
Copy link
Member

closes #3259

closes #3259

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 16, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #3309 (10a23e4) into main (ed42de3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files         115      115           
  Lines        9098     9099    +1     
=======================================
+ Hits         7678     7679    +1     
  Misses       1148     1148           
  Partials      272      272           
Impacted Files Coverage Δ
pkg/config/config.go 95.18% <ø> (ø)
internal/pipe/nfpm/nfpm.go 93.55% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 3f60327 into main Aug 16, 2022
8 checks passed
@caarlos0 caarlos0 deleted the nfpm-changelog branch Aug 16, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nfpm bindings should support RPM "Provides" & "Changelog"
1 participant