Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eventual race condition in artifacts #3310

Merged
merged 6 commits into from Aug 16, 2022
Merged

fix: eventual race condition in artifacts #3310

merged 6 commits into from Aug 16, 2022

Conversation

caarlos0
Copy link
Member

Signed-off-by: Carlos A Becker caarlos0@users.noreply.github.com

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 16, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2022
@caarlos0 caarlos0 marked this pull request as ready for review August 16, 2022 03:05
@caarlos0 caarlos0 added the bug Something isn't working label Aug 16, 2022
@vercel vercel bot temporarily deployed to Preview August 16, 2022 03:05 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 16, 2022 03:07 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2022
@vercel vercel bot temporarily deployed to Preview August 16, 2022 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:18 Inactive
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:35 Inactive
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:37 Inactive
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #3310 (c93af4a) into main (ed42de3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3310   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files         115      115           
  Lines        9098     9100    +2     
=======================================
+ Hits         7678     7680    +2     
  Misses       1148     1148           
  Partials      272      272           
Impacted Files Coverage Δ
internal/artifact/artifact.go 88.00% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit c83663c into main Aug 16, 2022
8 checks passed
@caarlos0 caarlos0 deleted the fix-race branch August 16, 2022 05:05
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant