Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove gofish #3312

Merged
merged 3 commits into from Aug 16, 2022
Merged

feat: remove gofish #3312

merged 3 commits into from Aug 16, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 16, 2022

was deprecated long enough.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 16, 2022
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 16, 2022
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:00 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review August 16, 2022 04:00
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #3312 (d00df24) into main (482a6f5) will increase coverage by 0.20%.
The diff coverage is n/a.

Current head d00df24 differs from pull request most recent head 38c40da. Consider uploading reports for the commit 38c40da to get more accurate results

@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   84.13%   84.33%   +0.20%     
==========================================
  Files         116      115       -1     
  Lines        9342     9104     -238     
==========================================
- Hits         7860     7678     -182     
+ Misses       1195     1154      -41     
+ Partials      287      272      -15     
Impacted Files Coverage Δ
internal/artifact/artifact.go 87.91% <ø> (+0.63%) ⬆️
internal/pipe/publish/publish.go 78.57% <ø> (ø)
pkg/config/config.go 95.18% <ø> (ø)
internal/golden/golden.go 75.60% <0.00%> (-7.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:14 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 16, 2022 04:16 Inactive
@caarlos0 caarlos0 merged commit 08e7038 into main Aug 16, 2022
3 of 5 checks passed
@caarlos0 caarlos0 deleted the rm-gofish branch August 16, 2022 04:16
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant