Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update discord webhook library #3320

Merged

Conversation

TopiSenpai
Copy link
Contributor

This commit will update the discord webhook library. I deprecated https://github.com/DisgoOrg/disgohook a while ago and saw it being used here. The module was moved into https://github.com/disgoorg/disgo/tree/development/webhook

disgohook had a few bugs which are resolved in the new module and also the new module should be nicer to use in general!

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2022
@caarlos0
Copy link
Member

ah super cool, thanks for the lib and for the PR!

FWIW, It might be good to deprecate the module: https://tip.golang.org/ref/mod#go-mod-file-module-deprecation

@caarlos0 caarlos0 added the dependencies Pull requests that update a dependency file label Aug 18, 2022
@caarlos0 caarlos0 changed the title Chore: update discord webhook library feat(deps): update discord webhook library Aug 18, 2022
@TopiSenpai
Copy link
Contributor Author

oh totally forgot about this ty!

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #3320 (4c521a9) into main (46e9db4) will decrease coverage by 0.00%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   84.12%   84.11%   -0.01%     
==========================================
  Files         115      115              
  Lines        9133     9134       +1     
==========================================
  Hits         7683     7683              
- Misses       1178     1179       +1     
  Partials      272      272              
Impacted Files Coverage Δ
internal/pipe/discord/discord.go 50.00% <7.69%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 6183c3f into goreleaser:main Aug 18, 2022
5 of 8 checks passed
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants