Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay github tag creation #3330

Merged
merged 1 commit into from Aug 21, 2022
Merged

feat: delay github tag creation #3330

merged 1 commit into from Aug 21, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 21, 2022

closes #3044

What happens is that, if the tag is created only locally, it'll create the tag in the remote upon creating the release. The tag still needs to be created locally though!

@bep let me know if that works for you.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 21, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Aug 21, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 21, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #3330 (a5b713c) into main (a1e681c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   84.11%   84.10%   -0.01%     
==========================================
  Files         115      115              
  Lines        9134     9135       +1     
==========================================
  Hits         7683     7683              
- Misses       1179     1180       +1     
  Partials      272      272              
Impacted Files Coverage Δ
internal/client/github.go 34.00% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0
Copy link
Member Author

ok, I just tested this again (100 times) and it works.
Will merge!

@caarlos0 caarlos0 merged commit 95bba02 into main Aug 21, 2022
6 of 8 checks passed
@caarlos0 caarlos0 deleted the delay branch Aug 21, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 21, 2022
caarlos0 added a commit that referenced this pull request Aug 23, 2022
We should not imply the target_commitish, as some users might want to
have the code in one repo and the releases in another (e.g. private
code, public releases), so the commit might not be there.

We should instead allow the user to set the `target_commitish` (or not),
and pass it down to the github api.

refs 95bba02
refs #3044
refs #3330

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay creation of remote tag
1 participant