Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source archive add subfolders #3343

Merged
merged 4 commits into from Aug 25, 2022
Merged

fix: source archive add subfolders #3343

merged 4 commits into from Aug 25, 2022

Conversation

caarlos0
Copy link
Member

--add-file adds only the --prefix joined with the basename of the added file, so, adding a folder like vendor would break havoc.

this basically writes our own source archives (which are more compressed) and allows to add an entire folder easily, as well as other mappings as archives already supports.

refs #3102 #2911

refs #3102 #2911

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2022
@caarlos0 caarlos0 added bug Something isn't working and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 25, 2022 04:54 Inactive
@vercel vercel bot temporarily deployed to Preview August 25, 2022 04:55 Inactive
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #3343 (fa87dec) into main (12c4256) will decrease coverage by 0.13%.
The diff coverage is 54.28%.

Current head fa87dec differs from pull request most recent head 83b3b2d. Consider uploading reports for the commit 83b3b2d to get more accurate results

@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
- Coverage   83.93%   83.79%   -0.14%     
==========================================
  Files         115      115              
  Lines        9210     9208       -2     
==========================================
- Hits         7730     7716      -14     
- Misses       1204     1212       +8     
- Partials      276      280       +4     
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/sourcearchive/source.go 70.42% <54.28%> (-17.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 25, 2022 05:07 Inactive
@caarlos0 caarlos0 merged commit d7acf21 into main Aug 25, 2022
7 of 9 checks passed
@caarlos0 caarlos0 deleted the src branch August 25, 2022 05:15
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant