Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard changelog commit abbrev behind config #3349

Merged
merged 3 commits into from Aug 30, 2022
Merged

Conversation

caarlos0
Copy link
Member

this allows the user to specify the abbrev lenght to use, and will also add the option to omit the commit hash altogether by setting it to -1.
default is doing nothing

closes #3348

this allows the user to specify the abbrev lenght to use, and will also add the option to omit the commit hash altogether by setting it to -1.
default is doing nothing

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2022
@caarlos0 caarlos0 added bug Something isn't working and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2022
@caarlos0 caarlos0 self-assigned this Aug 30, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #3349 (bba8e0f) into main (c812210) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   83.86%   83.90%   +0.04%     
==========================================
  Files         115      115              
  Lines        9208     9215       +7     
==========================================
+ Hits         7722     7732      +10     
+ Misses       1208     1206       -2     
+ Partials      278      277       -1     
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/client/github.go 32.27% <100.00%> (-0.54%) ⬇️
internal/pipe/changelog/changelog.go 91.45% <100.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit efdba10 into main Aug 30, 2022
10 of 11 checks passed
@caarlos0 caarlos0 deleted the commit-abbrev branch Aug 30, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog in GitHub release no longer has commit links
1 participant