Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ruleguard and semgrep scans and fixes #3364

Merged
merged 6 commits into from Sep 11, 2022
Merged

fix: ruleguard and semgrep scans and fixes #3364

merged 6 commits into from Sep 11, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Sep 11, 2022

run semgrep-go ruleguard and semgrep scans

https://github.com/dgryski/semgrep-go

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Sep 11, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2022
@caarlos0 caarlos0 marked this pull request as ready for review September 11, 2022 14:58
@vercel vercel bot temporarily deployed to Preview September 11, 2022 14:58 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview September 11, 2022 15:00 Inactive
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #3364 (487d4af) into main (5185b5b) will decrease coverage by 0.01%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   83.90%   83.89%   -0.02%     
==========================================
  Files         115      115              
  Lines        9215     9208       -7     
==========================================
- Hits         7732     7725       -7     
  Misses       1206     1206              
  Partials      277      277              
Impacted Files Coverage Δ
internal/pipe/aur/aur.go 80.15% <0.00%> (ø)
internal/pipe/release/release.go 91.36% <0.00%> (ø)
internal/pipe/blob/upload.go 74.84% <66.66%> (-0.62%) ⬇️
cmd/config.go 100.00% <100.00%> (ø)
internal/exec/exec_mock.go 9.52% <100.00%> (ø)
internal/git/config.go 90.56% <100.00%> (ø)
internal/pipe/archive/archive.go 93.83% <100.00%> (ø)
internal/pipe/env/env.go 97.14% <100.00%> (ø)
internal/testlib/git.go 100.00% <100.00%> (ø)
pkg/context/context.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2022
@vercel vercel bot temporarily deployed to Preview September 11, 2022 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview September 11, 2022 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview September 11, 2022 17:34 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 changed the title chore: ruleguard and semgrep scans fix: ruleguard and semgrep scans and fixes Sep 11, 2022
@vercel vercel bot temporarily deployed to Preview September 11, 2022 18:05 Inactive
@caarlos0 caarlos0 merged commit 8cb4eb1 into main Sep 11, 2022
11 of 14 checks passed
@caarlos0 caarlos0 deleted the scans branch September 11, 2022 18:32
@github-actions github-actions bot added this to the 1.11.0 milestone Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant